fix: update combo-box integration tests (#383)

Web-component: combo-box Fixes: vaadin/vaadin-combo-box#965 Details: with the update of 5.4.4 wc overlay is closed when there is no items filter, so `customItemFilter` test should be updated as well. Co-authored-by: Yuriy Yevstihnyeyev <yuriy@vaadin.com>
vaadin · Nov 10, 2020 · 91dc7c8 · 91dc7c8
1 parent c4ed528
commit 91dc7c8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/...ntegration-tests/src/test/java/com/vaadin/flow/component/combobox/test/LazyLoadingIT.java b/...ntegration-tests/src/test/java/com/vaadin/flow/component/combobox/test/LazyLoadingIT.java
@@ -375,8 +375,9 @@ public void customItemFilter() {
 
         filterBox.setFilter("Person");
 
-        Assert.assertEquals("None of the items should match the filter.", 0,
-                getNonEmptyOverlayContents().size());
+        Assert.assertEquals("None of the items should match the filter " +
+                        "and overlay is not displayed", 0,
+                $("vaadin-combo-box-overlay").all().size());
 
         filterBox.setFilter("10");
 
@@ -465,7 +466,7 @@ public void filterAndSelectItemNotOnFirstPage_setCurrentValue_valueCorrect() {
         Assert.assertEquals(item, getSelectedItemLabel(stringBox));
     }
 
-    @Test 
+    @Test
     public void autoOpenDisabled_setValue_valueChanged() {
         String item = "Item 151";
         stringBox.openPopup();

diff --git a/...bo-box-flow/src/main/java/com/vaadin/flow/component/combobox/GeneratedVaadinComboBox.java b/...bo-box-flow/src/main/java/com/vaadin/flow/component/combobox/GeneratedVaadinComboBox.java
@@ -295,8 +295,8 @@
 @Generated({ "Generator: com.vaadin.generator.ComponentGenerator#1.5-SNAPSHOT",
         "WebComponent: Vaadin.ComboBoxElement#5.0.0", "Flow#1.5-SNAPSHOT" })
 @Tag("vaadin-combo-box")
-@NpmPackage(value = "@vaadin/vaadin-combo-box", version = "5.4.3")
 @HtmlImport("frontend://bower_components/vaadin-combo-box/src/vaadin-combo-box.html")
+@NpmPackage(value = "@vaadin/vaadin-combo-box", version = "5.4.5")
 @JsModule("@vaadin/vaadin-combo-box/src/vaadin-combo-box.js")
 public abstract class GeneratedVaadinComboBox<R extends GeneratedVaadinComboBox<R, T>, T>
         extends AbstractSinglePropertyField<R, T>