fix: Safari 12 rendering issue #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A CSS animation used to detect element rendering (by triggering an animation event) was triggering a weird rendering bug in Safari 12 where elements would sometimes be shown in wildly incorrect positions. This is now fixed. Fixes #110
|
|
web-padawan
approved these changes
Jun 3, 2019
|
CI seems to be failing because "no spacing on edges" tests are failing on Edge 18. I verified locally that they do not fail on Edge 17 but do fail on Edge 18. I will create a new issue about this. Not related to this change, so will merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CSS animation used to detect element rendering (by triggering an animation event) was triggering a weird rendering bug in Safari 12 where elements would sometimes be shown in wildly incorrect positions. This is now fixed.
Fixes #110
This change is