Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for P3 conversion #70

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Prepare for P3 conversion #70

merged 1 commit into from
Apr 3, 2018

Conversation

platosha
Copy link
Contributor

@platosha platosha commented Apr 3, 2018 •
edited
Loading

Fixes #68

This change is Reviewable

@web-padawan
Copy link
Member

:lgtm:

Reviewed 15 of 16 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@platosha platosha changed the base branch from master to p3-preview April 3, 2018 10:24
@platosha
Copy link
Contributor Author

platosha commented Apr 3, 2018

Oops, was targeting master. Fixed now.

@web-padawan web-padawan merged commit d3e0ebb into p3-preview Apr 3, 2018
@web-padawan web-padawan deleted the p3-preview-dev branch April 3, 2018 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@platosha @web-padawan