This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
fix: prevent NPE for client-side only grids #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #1077 `ItemCache#ensureSubCacheForScaledIndex` method is changed by gridConnector, so it will make any grid on the page use the new implementation. That leads to a call from undefined object in case of a grid entirely defined on the client side needs to call this method. This change stores the original implementation and calls it when the grid doesn't have a `$connector` object.
DiegoCardoso
commented
Sep 4, 2020
vaadin-grid-flow/src/main/resources/META-INF/resources/frontend/gridConnector.js
Show resolved
Hide resolved
vaadin-grid-flow/src/main/resources/META-INF/resources/frontend/gridConnector.js
Show resolved
Hide resolved
tomivirkki
approved these changes
Sep 9, 2020
DiegoCardoso
added a commit
that referenced
this pull request
Sep 9, 2020
DiegoCardoso
added a commit
that referenced
this pull request
Sep 9, 2020
DiegoCardoso
added a commit
that referenced
this pull request
Sep 9, 2020
DiegoCardoso
added a commit
that referenced
this pull request
Sep 9, 2020
DiegoCardoso
added a commit
that referenced
this pull request
Sep 9, 2020
DiegoCardoso
added a commit
that referenced
this pull request
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1077
ItemCache#ensureSubCacheForScaledIndexmethod is changed bygridConnector, so it will make any grid on the page use the new implementation. That leads to a call from undefined object in case of a grid entirely defined on the client side needs to call this method.This change stores the original implementation and calls it when the grid doesn't have a
$connectorobject.