Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility support #1015

Closed
tomivirkki opened this issue Sep 28, 2017 · 4 comments
Closed

Accessibility support #1015

tomivirkki opened this issue Sep 28, 2017 · 4 comments
Assignees
@platosha
Labels
a11y Accessibility issue
Milestone
4.0.0-alpha4

Comments

@tomivirkki
Copy link
Member

Finish accessibility support
platosha added a commit that referenced this issue Oct 2, 2017
@platosha
Reimpliment accessibility based on WAI-ARIA 1.1
d8e46c5 
Fixes #1015

- Use `aria-rowcount`, `aria-colcount` on table

- Use `aria-rowindex` on rows to indicate row numbers

- Use `aria-selected` on cells to indicate selection

- Use `aria-expanded`, `aria-controls` on cells to indicate row details
  toggle states

- `<vaadin-grid-sorter>` sets `aria-sort` on parent cells

- Add tests for all above and structural grid/row/gridcell roles in HTML

- Remove hardcoded english textual announcements
@platosha platosha mentioned this issue Oct 2, 2017
Merged
platosha added a commit that referenced this issue Oct 3, 2017
@platosha
Reimpliment accessibility based on WAI-ARIA 1.1
d9933f5 
Fixes #1015

- Use `aria-rowcount`, `aria-colcount` on table

- Use `aria-rowindex` on rows to indicate row numbers

- Use `aria-selected` on cells to indicate selection

- Use `aria-expanded`, `aria-controls` on cells to indicate row details
  toggle states

- `<vaadin-grid-sorter>` sets `aria-sort` on parent cells

- Add tests for all above and structural grid/row/gridcell roles in HTML

- Remove hardcoded english textual announcements
@tomivirkki tomivirkki added this to the 4.0.0-alpha4 milestone Oct 3, 2017
platosha added a commit that referenced this issue Oct 3, 2017
@platosha
Reimpliment accessibility based on WAI-ARIA 1.1
c893c15 
Fixes #1015

- Use `aria-rowcount`, `aria-colcount` on table

- Use `aria-rowindex` on rows to indicate row numbers

- Use `aria-selected` on cells to indicate selection

- Use `aria-expanded`, `aria-controls` on cells to indicate row details
  toggle states

- `<vaadin-grid-sorter>` sets `aria-sort` on parent cells

- Add tests for all above and structural grid/row/gridcell roles in HTML

- Remove hardcoded english textual announcements
platosha added a commit that referenced this issue Oct 3, 2017
@platosha
Reimpliment accessibility based on WAI-ARIA 1.1
0dbd92e 
Fixes #1015

- Use `aria-rowcount`, `aria-colcount` on table

- Use `aria-rowindex` on rows to indicate row numbers

- Use `aria-selected` on cells to indicate selection

- Use `aria-expanded`, `aria-controls` on cells to indicate row details
  toggle states

- `<vaadin-grid-sorter>` sets `aria-sort` on parent cells

- Add tests for all above and structural grid/row/gridcell roles in HTML

- Remove hardcoded english textual announcements
platosha added a commit that referenced this issue Oct 3, 2017
@platosha
Reimpliment accessibility based on WAI-ARIA 1.1
3256079 
Fixes #1015

- Use `aria-rowcount`, `aria-colcount` on table

- Use `aria-rowindex` on rows to indicate row numbers

- Use `aria-selected` on cells to indicate selection

- Use `aria-expanded`, `aria-controls` on cells to indicate row details
  toggle states

- `<vaadin-grid-sorter>` sets `aria-sort` on parent cells

- Add tests for all above and structural grid/row/gridcell roles in HTML

- Remove hardcoded english textual announcements
@platosha
Copy link
Contributor

platosha commented Oct 3, 2017 •
edited

Accessibility Feature Support Matrix

The following would have effect after PR #1023 is merged.

OS + Reader + Browser Grid and cell roles
(role="grid", role="gridcell")		 Column headers announced on body cells
(role="columnheader")		 Total number of rows and columns
(aria-rowcount, aria-colcount)		 Row numbers
(aria-rowindex)		 Row selection
(aria-selected)		 Row details toggle state
(aria-expanded)		 Sorter state
(aria-sort)
Windows 10 + NVDA 2017.3 + Chrome 61 ✅
Valid		 ✅
Valid		 ⭕
Missing		 ✅
Valid		 ✅
Valid		 ✅
Valid		 ⚠️
Not live
Windows 10 + Jaws + Chrome 61 ✅
Valid		 ✅
Valid		 ⭕
Missing		 ❌
Invalid		 ✅
Valid		 ✅
Valid		 ⚠️
Not live
Windows 10 + Narrator + Edge 16 ✅
Valid		 ⭕
Missing		 ❌
Invalid		 ❌
Invalid		 ⚠️
Not live		 ✅
Valid		 ⚠️
Not live
MacOS Sierra + VoiceOver + Safari 11.0 ✅
Valid		 ⭕
Missing		 ❌
Invalid		 ⭕
Missing		 ⭕
Missing		 ✅
Valid		 ⭕
Missing
MacOS Sierra + VoiceOver + Chrome 61 ❌
Invalid		 ⭕
Missing		 ❌
Invalid		 ⭕
Missing		 ⭕
Missing		 ✅
Valid		 ⭕
Missing
MacOS High Sierra + VoiceOver + Safari 11.0 ✅
Valid		 ⭕
Missing		 ❌
Invalid		 ⭕
Missing		 ⭕
Missing		 ✅
Valid		 ✅
Valid
MacOS High Sierra + VoiceOver + Chrome 61 ❌
Invalid		 ⭕
Missing		 ❌
Invalid		 ⭕
Missing		 ⭕
Missing		 ✅
Valid		 ✅
Valid
iOS 10.3 + VoiceOver + Safari ✅
Valid		 ✅
Valid		 ✅
Valid		 ✅
Valid		 ⭕
Missing		 ⭕
Missing		 ⭕
Missing
iOS 11.0 + VoiceOver + Safari ✅
Valid		 ✅
Valid		 ✅
Valid		 ✅
Valid		 ⭕
Missing		 ⭕
Missing		 ⚠️
Not live
Android 6.0.1 + Talkback + Chrome 50.0 ✅
Valid		 ⚠️
Top-level group name only		 ❌
Invalid		 ⭕
Missing		 ✅
Valid		 ⭕
Missing		 ⭕
Missing
Android 7.0 + Talkback + Chrome 61.0 ✅
Valid		 ⚠️
Top-level group name only		 ❌
Invalid		 ⭕
Invalid		 ✅
Valid		 ✅
Valid		 ⭕
Missing

@knoobie
Copy link

knoobie commented Oct 24, 2017

Hey @platosha where did you find this support matrix or did you created it yourself?

@platosha
Copy link
Contributor

@knoobie created myself after trying <vaadin-grid> with these platform/UA/reader combinations. Tried the PR branch back then, now this is aleady merged.

@knoobie
Copy link

knoobie commented Oct 24, 2017

@platosha Oh, thanks! Your self-study reflects the things I noticed with our sightless user - aria-sort in on Windows broken..

@web-padawan web-padawan mentioned this issue Jun 13, 2019
Closed
@rolfsmeds rolfsmeds added the a11y Accessibility issue label Nov 24, 2020
@web-padawan web-padawan mentioned this issue Oct 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@platosha platosha

Labels
a11y Accessibility issue
Projects
None yet
Milestone
4.0.0-alpha4
Development

No branches or pull requests
4 participants
@platosha @tomivirkki @knoobie @rolfsmeds