-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve row details experience (loading/animation sequence) #166
Comments
I am going to try out another animated/interactive prototype tool for designing the details row transition: UI prototyping with Keynote. Benefits should be that it is quick to learn, integrates easily with Photoshop or Sketch by simple copy/paste, supports various transitions, custom slide sizes and even exporting a document as an interactive html page for prototype testing. Reviewed also quickly Pixate http://www.pixate.com/. Seems to be aimed for mobile/touch device design and has a bit not-intuitive workflow and animation properties. Too limited for my taste. You would have to install also the mobile app to view and try out the designs. Not able to for example export the project for laptop screen that could be viewed with any plugins. |
Added a video demonstrating roughly the details row transition sequence: https://drive.google.com/open?id=0BzkWbWvgmkIxZ3huYkoxS25QZHc Also an interactive proto is available (runs only in Safari, weird): Note: Keynote was not a huge success implementing this demo. Potential tool for more straightforward navigation-type protos, though. TODO:
|
The sequence is pretty much how I imaged it, except that the spinner should look like the one we already use for lazy loading rows or the Another idea I had for the loading sequence, roughly (click the "row" to toggle it): http://codepen.io/jouni/pen/JYKOOy How do you feel about the alternatives? Is the second one too ambiguous? The first one gives a more clear indication that new content will appear below the row, I think. But the second one feels more elegant visually (when polished properly), so I’m a little torn :) |
About the spinner design: I agree it should be similar to Your alternative looks cool and is elegant, but my first reaction was not to start waiting for anything to lazy load. I was a bit confused what was going on, until the details row appeared. I think it would be a more safe bet to rely on the spinner. |
I agree. Our default feature should use the spinner, but the other option would be nice to allow technically. |
To finalize this task, I think all we need is to define the exact pixels and timings for the transitions. |
Animation sequence
|
Spinner
|
Not really sure if we technically want to use paper-spinner, since it’s an extra dependency for vaadin-grid in that case. Also, technically, implementing that animation using CSS requires quite a lot of elements, and perhaps we could start with a similarly simple spinner that we currently use when lazy loading rows? The animations should of course be customizable by the developer, so perhaps we need to support having any arbitrary HTML for the spinner/loading indicator. |
I guess this is no longer relevant with grid > 1.0. The row details content isn't loaded from a data provider or such but it's a defined in a template. If a developer wants to lazily load the details content on open, that's possible with template bindings, but the grid itself would still be unaware of the content loading lazily. This means that the developer can create a loading sequence he desires by utilizing the row details template. Reopen if I got it wrong. |
Yeah, this is a “user space” problem. Might still be a nice convenience/helper element that does the progress indication for you – but that’s just a nice-to-have, we have plenty of should-have type of enhancements waiting as well 😅 |
The current behavior is less than great, as there is no animation for the opening. Also, if the content of the element is provided lazyly (which should be possible to do), then the row detail element should show some loading animation before the actual content is available, and after that do the opening animation.
The loading indicator and opening transition duration and easing should be customizable by the theme.
UI Design
The text was updated successfully, but these errors were encountered: