Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mousedown event on "select all" checkbox scrolls the viewport (OS X Safari) #53

Closed
jouni opened this issue Jul 6, 2015 · 3 comments
Closed

Comments

@jouni
Copy link
Member

jouni commented Jul 6, 2015

If I have a partially visible grid (which is not focused) in the browser viewport (i.e. the top part visible), a mousedown event on the "select all" checkbox will cause a focus call on the v-grid element, which will make the browsers scroll the element fully into viewport. This makes the subsequent mouseup event miss the "select all" checkbox, and the selection mode is not changed.

The issue was introduced in 7b8c3c5

@jouni jouni added bug Something isn't working <v-grid> labels Jul 6, 2015
@jouni jouni added this to the Next milestone Jul 6, 2015
@jouni jouni changed the title Mousedown event on "select all" checkbox scrolls the viewport Mousedown event on "select all" checkbox scrolls the viewport (OS X Safari) Jul 6, 2015
@jouni jouni modified the milestones: Next, 0.3.0 Jul 10, 2015
@amahdy
Copy link

amahdy commented Jul 20, 2015

This issue happens for any selection checkbox, not just select all. Able to reproduce in Chrome OSX.

@amahdy
Copy link

amahdy commented Jul 28, 2015

Solving this https://dev.vaadin.com/ticket/18521 and removing the focusGridIfSelectAllClicked method at all should resolve this.

@jouni jouni modified the milestone: 0.3.0 Aug 11, 2015
@jouni jouni removed <v-grid> bug Something isn't working labels Sep 11, 2015
@jouni
Copy link
Member Author

jouni commented Nov 7, 2016

Won’t fix for 1.x. 2.0 does not exhibit the same behavior, at least for now. Once we keyboard navigation (#487) is added for 2.0, we should try to avoid reintroducing this bug.

@jouni jouni closed this as completed Nov 7, 2016
HJK181 pushed a commit to CommerceExperts/vaadin-grid that referenced this issue Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants