-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dom Observers for Templates #890
Comments
@Saulis ... we're keen to prototype vaadin-grid (v3 supporting polymer 2) in an angular4 context. Is this suggested fix alot of work to get in? Thanks. |
@hotforfeature @Analect I've made a POC branch here |
I'll test out that branch and see how it works in Angular 4. |
I tested and so far it looks like it's working! There's one change that needs to be made though: https://github.com/vaadin/vaadin-grid/blob/master/vaadin-grid-column.html#L97
to ensure the templatizer doesn't get replaced. |
@Saulis ... posting @hotforfeature preliminary demo here (hope that's OK) based on those changes you had implemented on the Seems I forgot to add. Sorry. https://github.com/hotforfeature/origami/tree/vaadin/demo |
@Saulis ... do you think you might be able to roll in your changes in the |
@hotforfeature @Analect I've added the |
@Saulis works perfectly! |
@Saulis ... do you think your fix on |
@Analect need to do some additional fixes to make it releasable, but I'll try to get a PR up asap. |
Master build is not green, so moving this to the backlog until we spend some time to fix master. |
Discussed with @Saulis. The grid won't work with Angular 2 and other libraries where elements are created and attached programatically.
Specifically, the column templates in Angular 2 are first created, then attached to
<vaadin-grid-column>
before child elements are attached to the<template>
.Adding some observers for when templates or their content changes will resolve any issues with programmatically creating and attaching a grid and its children. Alternatively, we could expose an API to inform the grid that its templates or columns have changed so that it knows to re-stamp them.
Relates to hotforfeature/origami#18 for Angular 4/Polymer 2 support.
The text was updated successfully, but these errors were encountered: