Icon 'workplace' showing as double image

[mpilone]

In the 8.1.0 Vaadin-Icons.woff file, the 'workplace' icon appears as a double image. From the best I can tell it is rendering both the hospital and workplace icon back to back. I used an online font viewer (http://torinak.com/font/lsfont.html) to verify that something looks odd at that point in the icon file. For now we're just avoiding that icon but it would be nice to have it available.

[jouni]

Thanks for the report! You’re correct, the exported SVG that is used for generating the font contains another icon outside the actual icon canvas, which becomes visible if the element you use the icons in is not using overflow: hidden;.

[jouni]

Would appreciate a PR for this one. You should be able to generate new font files by uploading the current SVG font to icomoon.io and exporting new web fonts with it. The most crucial part is making sure that the same unicode characters are used for the same icons as before, but I think those should map automatically with icomoon.

[mpilone]

We started looking into fixing this and found that in the 3.0 tag, the issue isn't present. However it is present in the 3.0.1 build (I can't find a corresponding tag) that Vaadin Framework is depending on. The latest 4.1.0 tag of Vaadin Icons also looks correct.

So I think the issue is already fixed in the Vaadin Icons repo, but the 3.0.1 build that Vaadin Framework is using has the bug. It seems like the right fix would be to update the Vaadin Framework dependency to 4.1.0 and the issue would be resolved. I don't know your build process but it seems like the issue was introduced with the 3.0.1 build that doesn't match a tag in the icons repo.

[jouni]

It seems I’ve actually tried to fix this almost a year ago, in 7f2451a

I only fixed the web fonts back then, now I actually fixed the SVG source file as well in fb85ca5

[web-padawan]

Closing as fixed per above comment.