-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo should have a code example on how to use vaadin-icons with iron-icon #46
Comments
we already discussed when migrating the elements, and ended deciding that code is useless. |
I still think the issue is valid, that we should offer the documentation/example somewhere. The current single example is silly, as it only lists all the icons without really offering much else. Yes, you can use the browser search to hunt for icons, but we should have a separate page where you can search the icons using the metadata provided in https://github.com/vaadin/vaadin-icons/blob/master/assets/vaadin-font-icons.json (the name of that file is a bit misleading as well, btw). On top of that, the first example should be a single icon, with a clear code example what you need to do to use I suppose we should open new issues for each of those. |
I found a way to target basic demo and searchable list in the same page. |
The demo should contain at least a small code example to show how to import the iconset and how to use it with
<iron-icon>
. Now it just lists the icons but there is no code shown. This is a bit weird at least when viewing via https://vaadin.com/elements/vaadin-icons/html-examples/icons-basic-demos unless you’re already familiar withiron-icon
and iconsets.The text was updated successfully, but these errors were encountered: