Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate demo link in doc viewer #73

Merged
merged 1 commit into from Mar 15, 2019
Merged

Remove duplicate demo link in doc viewer #73

merged 1 commit into from Mar 15, 2019

Conversation

Haprog
Copy link
Contributor

@Haprog Haprog commented Mar 14, 2019

Tested locally (after running polymer analyze vaadin-* > analysis.json) that this change gets rid of the extra "demo" link in the doc viewer. This will probably also fix it for webcomponents.org

Should fix #43 when there is a new version in webcomponents.org.


This change is Reviewable

Tested locally (after running "polymer analyze vaadin-* > analysis.json") that this change gets rid of the extra "demo" link in the doc viewer. This will probably also fix it for webcomponents.org

Should fix #43 when there is a new version in webcomponents.org.
@CLAassistant
Copy link

CLAassistant commented Mar 14, 2019

CLA assistant check
All committers have signed the CLA.

@Haprog
Copy link
Contributor Author

Haprog commented Mar 14, 2019

My testing showed that if there is no @demo annotation, there are no demo links. And if there is anything after if on the same line, the demo link is duplicated (and the link title and URL of one or both links change in very weird manner). If the line only has @demo then there is only one link (as wanted) and the link works correctly, but there doesn't seem to be any way in this case to modify the link text (it will be lowercase "demo") other than directly editing analysis.json after running polymer analyze vaadin-* > analysis.json.

I think this weird behaviour of duplicate demo link and how they behave when there's anything after the @demo on the line is a bug in polymer analyzer and due to this being a special case of "pseudo element" documentation instead of documenting a real custom element (since vaadin-icons.html does not define a custom element).

The same issue seems to affect the Polymer 2 version of iron-icon here: https://www.webcomponents.org/element/PolymerElements/iron-icons

@web-padawan web-padawan merged commit 99705e0 into master Mar 15, 2019
@web-padawan web-padawan deleted the fix/43 branch March 15, 2019 11:18
web-padawan pushed a commit to vaadin/web-components that referenced this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The demo doesn't work in webcomponents.org
3 participants