New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround selected item icon not shown in IE11 #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @web-padawan)
theme/lumo/vaadin-list-box-styles.html, line 37 at r1 (raw file):
} /* TODO(web-padawan): a workaround to display checkmark in IE11 when not used in dropdown-menu */
What means this TODO? This sentence is not clear to me if you need to figure-out a workaround or you need to remove this workaround
a5524c6
to
7a85329
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @web-padawan)
theme/lumo/vaadin-list-box-styles.html, line 37 at r1 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
What means this TODO? This sentence is not clear to me if you need to figure-out a workaround or you need to remove this workaround
Updated the comment to remove TODO, as this is something we only can replace later once we refactor and introduce "unselectable" list-box, which is not planned at this point
There's a still a problem in IE11, before hovering on the items, the padding is not there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
Fixes #38
Depends on vaadin/vaadin-list-mixin#42
For some reason, in IE11 items do not pick up the CSS custom property defined on the list-box element. This change workarounds that, without it
::before
pseudo elements never appear.Note that this also needs calling
updateStyles()
: without that, the original issue on the GIF happens IE11 (::before
pseudo elements only appear on hover).This change is