Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround selected item icon not shown in IE11 #43

Merged
merged 1 commit into from Aug 9, 2018

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Aug 6, 2018

Fixes #38

Depends on vaadin/vaadin-list-mixin#42

For some reason, in IE11 items do not pick up the CSS custom property defined on the list-box element. This change workarounds that, without it ::before pseudo elements never appear.

Note that this also needs calling updateStyles(): without that, the original issue on the GIF happens IE11 (::before pseudo elements only appear on hover).


This change is Reviewable

Copy link
Contributor

@yuriy-fix yuriy-fix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@manolo manolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @web-padawan)


theme/lumo/vaadin-list-box-styles.html, line 37 at r1 (raw file):

      }

      /* TODO(web-padawan): a workaround to display checkmark in IE11 when not used in dropdown-menu */

What means this TODO? This sentence is not clear to me if you need to figure-out a workaround or you need to remove this workaround

Copy link
Member Author

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @web-padawan)


theme/lumo/vaadin-list-box-styles.html, line 37 at r1 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

What means this TODO? This sentence is not clear to me if you need to figure-out a workaround or you need to remove this workaround

Updated the comment to remove TODO, as this is something we only can replace later once we refactor and introduce "unselectable" list-box, which is not planned at this point

@sohrabtaee
Copy link
Contributor

There's a still a problem in IE11, before hovering on the items, the padding is not there.

@sohrabtaee
Copy link
Contributor

:lgtm:

Copy link
Member

@manolo manolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@manolo manolo merged commit 5a678ce into master Aug 9, 2018
@manolo manolo deleted the fix/lumo-checkmark-ie branch August 9, 2018 09:45
@manolo manolo removed the in review label Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants