Add check for vaadin-item import #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
requested changes
Sep 16, 2019
src/vaadin-list-box.html
Outdated
| @@ -91,11 +91,23 @@ | |||
| ready() { | |||
| super.ready(); | |||
| this.setAttribute('role', 'list'); | |||
|
|
|||
| this._debouncerCheckImport = Polymer.Debouncer.debounce( | |||
There was a problem hiding this comment.
The ready() will just be called once so there's no point in using a debouncer. Normal setTimeout() of 2000ms works fine here
There was a problem hiding this comment.
Good point, should we still be aligned with the vaadin-grid in terms of having _checkImport method or would it be better to move it inside timeout? 🤔
There was a problem hiding this comment.
Separate checkImport is fine imo
tomivirkki
approved these changes
Sep 17, 2019
yuriy-fix
force-pushed
the
check-for-item-import
branch
from
481da77
to
2237a3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52
Done the same way as in
vaadin-grid, but withoutFlattenedNodesObserverasvaadin-itemis going to be used anyway.