New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add password recovery instructions - Part 1 #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @tulioag)
src/vaadin-login.html, line 257 at r1 (raw file):
<vaadin-button class="login-button" theme="primary">Log in</vaadin-button> <vaadin-button id="forgotPasswordButton" class="forgot-password-button" theme="tertiary small" on-click="_forgotPassword" hidden="[[hideForgotPasswordButton]]">Forgot password</vaadin-button>
We should set the value to a hidden attribute directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @alexberazouski)
src/vaadin-login.html, line 257 at r1 (raw file):
Previously, alexberazouski wrote…
We should set the value to a hidden attribute directly
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Part 1 for #4
Included
Not included
This change is