Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password recovery instructions - Part 1 #20

Merged
merged 7 commits into from Nov 1, 2018

Conversation

tulioag
Copy link
Contributor

@tulioag tulioag commented Nov 1, 2018

Part 1 for #4
Included

  • Developer can show/hide the "Forgot password" button
  • Component should provide a callback (event) when the button is clicked

Not included

  • Developer is responsible for create how the instructions will be present to user

This change is Reviewable

@tulioag tulioag requested a review from a team November 1, 2018 12:53
Copy link

@alexberazouski alexberazouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r1.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @tulioag)


src/vaadin-login.html, line 257 at r1 (raw file):

          <vaadin-button class="login-button" theme="primary">Log in</vaadin-button>

          <vaadin-button id="forgotPasswordButton" class="forgot-password-button" theme="tertiary small" on-click="_forgotPassword" hidden="[[hideForgotPasswordButton]]">Forgot password</vaadin-button>

We should set the value to a hidden attribute directly

Copy link
Contributor Author

@tulioag tulioag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @alexberazouski)


src/vaadin-login.html, line 257 at r1 (raw file):

Previously, alexberazouski wrote…

We should set the value to a hidden attribute directly

Done.

Copy link

@alexberazouski alexberazouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 92.857%

Totals Coverage Status
Change from base Build 9: 0.5%
Covered Lines: 10
Relevant Lines: 10

💛 - Coveralls

@tulioag tulioag merged commit e7677a5 into master Nov 1, 2018
@tulioag tulioag deleted the feat/4-add-password-recovery-instructions branch November 1, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants