Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submit logic based on action property #30

Merged
merged 2 commits into from Nov 22, 2018

Conversation

DiegoCardoso
Copy link
Contributor

@DiegoCardoso DiegoCardoso commented Nov 20, 2018

  • If action is defined, then a sync POST is fired
  • Otherwise, fires a login event

Add documentantion and demo

Fixes #13


This change is Reviewable

- If `action` is defined, then a sync POST is fired
- Otherwise, fires a `login` event

Add documentantion and demo

Fixes #13
@coveralls
Copy link

coveralls commented Nov 20, 2018

Pull Request Test Coverage Report for Build 80

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 95.833%

Totals Coverage Status
Change from base Build 74: 0.5%
Covered Lines: 26
Relevant Lines: 26

💛 - Coveralls

Copy link

@alexberazouski alexberazouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tulioag)

@DiegoCardoso DiegoCardoso merged commit c9b464e into master Nov 22, 2018
@DiegoCardoso DiegoCardoso deleted the feature/#13-add-submit-callback branch November 22, 2018 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants