Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable component before fire any event #42

Merged
merged 1 commit into from Dec 5, 2018
Merged

Disable component before fire any event #42

merged 1 commit into from Dec 5, 2018

Conversation

alexberazouski
Copy link

@alexberazouski alexberazouski commented Dec 5, 2018 •
edited by DiegoCardoso

This change is Reviewable

DiegoCardoso
DiegoCardoso approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@alexberazouski alexberazouski merged commit 65420f3 into master Dec 5, 2018
peterblazejewicz pushed a commit to peterblazejewicz/vaadin-login that referenced this pull request Dec 5, 2018
@peterblazejewicz
Disable component before fire any event (vaadin#42)
a931e12 
Thanks!
@coveralls
Copy link

Pull Request Test Coverage Report for Build 137

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.203%
Totals Coverage Status
Change from base Build 130: 0.0%
Covered Lines: 53
Relevant Lines: 53
💛 - Coveralls

@alexberazouski alexberazouski deleted the fix-disabling branch December 18, 2018 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexberazouski @coveralls @DiegoCardoso