Expose parts for styling #62
Conversation
There was a problem hiding this comment.
How about showing an example of using those exposed parts in a demo?
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oluwasayo)
a discussion (no related file):
How about showing an example of using those exposed parts in a demo?
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: 4 of 8 files reviewed, 1 unresolved discussion (waiting on @oluwasayo)
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oluwasayo)
a discussion (no related file):
Previously, tulioag (Tulio Garcia) wrote…
How about showing an example of using those exposed parts in a demo?
Thanks for the demo. Some thoughts:
- Shouldn't we keep the basic demo as is and add a demo to the advanced section?
- I noticed that the "title with custom html" demo also has the image, which is confusing because it doesn't show the code to add it.
demo/custom-brand.jpg, line 0 at r2 (raw file):
This looks nice, thanks. Is this image free for use?
Move custom theme demo to advanced section Fixes #63
There was a problem hiding this comment.
Reviewable status: 6 of 10 files reviewed, 2 unresolved discussions (waiting on @tulioag and @oluwasayo)
demo/custom-brand.jpg, line at r2 (raw file):
Previously, tulioag (Tulio Garcia) wrote…
This looks nice, thanks. Is this image free for use?
The image is taken from bakery
There was a problem hiding this comment.
Reviewable status: 6 of 10 files reviewed, 1 unresolved discussion (waiting on @tulioag and @oluwasayo)
demo/custom-brand.jpg, line at r2 (raw file):
Previously, alexberazouski wrote…
The image is taken from bakery
Ok.
How did I not notice that? 😩
There was a problem hiding this comment.
Reviewed 4 of 5 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oluwasayo)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oluwasayo)
There was a problem hiding this comment.
Reviewable status:
There was a problem hiding this comment.
Reviewed 2 of 4 files at r2, 4 of 5 files at r3.
Reviewable status:
Fixes #5
Expose new parts
form-title,description,error-message-titleanderror-message-descriptionThis change is