Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: theme property for individual menu items #140

Merged
merged 5 commits into from
Nov 5, 2021

Conversation

tltv
Copy link
Member

@tltv tltv commented Oct 22, 2021

Backported changes for Vaadin 14 from
vaadin/web-components#2401. Part of
vaadin/flow-components#880.

Depends on vaadin/vaadin-context-menu#313.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@tltv tltv requested a review from yuriy-fix October 22, 2021 13:59
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2021

CLA assistant check
All committers have signed the CLA.

src/vaadin-menu-bar-interactions-mixin.html Outdated Show resolved Hide resolved
src/vaadin-menu-bar-buttons-mixin.html Outdated Show resolved Hide resolved
yuriy-fix and others added 2 commits November 5, 2021 13:12
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@web-padawan web-padawan merged commit 102d94e into master Nov 5, 2021
@web-padawan web-padawan deleted the feat/menu-bar-item-theme branch November 5, 2021 11:37
tltv added a commit to vaadin/flow-components that referenced this pull request Nov 9, 2021
alvarezguille pushed a commit to vaadin/flow-components that referenced this pull request Nov 10, 2021
This change enables theming individual menu bar items, for example to display one item as the primary item. As the menu bar uses the context menu to display submenus, most of the changes are in there.

* feat: allow theming individual menu items

Backported changes for Vaadin 14 from
vaadin/web-components#2066.

Depends on vaadin/vaadin-menu-bar#140.

Part of
#880.

* Bump vaadin-context-menu 4.6.0-alpha1 and vaadin-menu-bar  1.3.0-alpha1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants