-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: theme property for individual menu items #140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backported changes for Vaadin 14 from vaadin/web-components#2401. Part of vaadin/flow-components#880.
yuriy-fix
approved these changes
Nov 5, 2021
web-padawan
requested changes
Nov 5, 2021
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
approved these changes
Nov 5, 2021
tltv
added a commit
to vaadin/flow-components
that referenced
this pull request
Nov 9, 2021
Backported changes for Vaadin 14 from vaadin/web-components#2066. Depends on vaadin/vaadin-menu-bar#140. Part of #880.
9 tasks
alvarezguille
pushed a commit
to vaadin/flow-components
that referenced
this pull request
Nov 10, 2021
This change enables theming individual menu bar items, for example to display one item as the primary item. As the menu bar uses the context menu to display submenus, most of the changes are in there. * feat: allow theming individual menu items Backported changes for Vaadin 14 from vaadin/web-components#2066. Depends on vaadin/vaadin-menu-bar#140. Part of #880. * Bump vaadin-context-menu 4.6.0-alpha1 and vaadin-menu-bar 1.3.0-alpha1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported changes for Vaadin 14 from
vaadin/web-components#2401. Part of
vaadin/flow-components#880.
Depends on vaadin/vaadin-context-menu#313.
Type of change
Checklist
Additional for
Feature
type of change