Submit functionality #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pekam
reviewed
Feb 17, 2021
pekam
reviewed
Feb 17, 2021
web-padawan
requested changes
Feb 17, 2021
src/vaadin-message-input.js
Outdated
Comment on lines
58
to
59
| <vaadin-text-area value="{{text}}" placeholder="Message"></vaadin-text-area> | ||
| <vaadin-button theme="primary contained" on-click="submitMessage">Send</vaadin-button> |
There was a problem hiding this comment.
Please create vaadin-message-text-area and vaadin-message-button - see #28 (comment).
There was a problem hiding this comment.
I don't think it's meaningful to do in the scope of this PR.
I'll update #28 to have the responsibility for all these three cases.
- Rename `vaadinMessageInput.text` to `vaadinMessageInput.value`. - Rename `submitMessage()` to `_submit()`
Co-authored-by: Pekka Maanpää <pekkamaa@vaadin.com>
pekam
reviewed
Feb 17, 2021
Co-authored-by: Pekka Maanpää <pekkamaa@vaadin.com>
web-padawan
requested changes
Feb 17, 2021
pekam
reviewed
Feb 17, 2021
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Co-authored-by: Pekka Maanpää <pekkamaa@vaadin.com>
pekam
approved these changes
Feb 18, 2021
web-padawan
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17