Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Lumo Theme demo to Theme Variants #60

Merged
merged 1 commit into from Jul 24, 2018
Merged

Rename Lumo Theme demo to Theme Variants #60

merged 1 commit into from Jul 24, 2018

Conversation

samiheikki
Copy link
Contributor

@samiheikki samiheikki commented Jul 18, 2018 •
edited by tomivirkki

Connects to "Guidelines for component examples": Avoid using product specific names or words that do not describe the contents of the category.

This change is Reviewable

@coveralls
Copy link

coveralls commented Jul 18, 2018 •
edited

Pull Request Test Coverage Report for Build 372

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.3%) to 81.25%
Totals Coverage Status
Change from base Build 365: 6.3%
Covered Lines: 11
Relevant Lines: 12
💛 - Coveralls

web-padawan
web-padawan approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@web-padawan web-padawan merged commit 815d259 into master Jul 24, 2018
@web-padawan web-padawan deleted the rename-lumo-theme-demos branch July 24, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samiheikki @coveralls @web-padawan @tomivirkki