Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vaadin-scroll-container #78

Merged
merged 2 commits into from Feb 6, 2020
Merged

vaadin-scroll-container #78

merged 2 commits into from Feb 6, 2020

Conversation

alvarezguille
Copy link
Member

• Simple slotted component that will display scrollbars when its content is overflowing and can be used in existing layouts.

• Scroll should be auto by default and can be disabled on a specific direction

Fixes #77

• Simple slotted component that will display scrollbars when its content is overflowing and can be used in existing layouts.

• Scroll should be auto by default and can be disabled on a specific direction

Fixes #77
@claassistantio
Copy link

claassistantio commented Feb 5, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small notes, otherwise LGTM.

Not sure whether we want to have a demo for it or not?

src/vaadin-scroll-container.html Outdated Show resolved Hide resolved
src/vaadin-scroll-container.html Show resolved Hide resolved
test/scroll-container.html Outdated Show resolved Hide resolved
test/scroll-container.html Outdated Show resolved Hide resolved
src/vaadin-scroll-container.html Outdated Show resolved Hide resolved
@alvarezguille alvarezguille merged commit 3aef4b0 into master Feb 6, 2020
@alvarezguille alvarezguille deleted the 77-scroll-container branch February 6, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vaadin-scroll-container
4 participants