Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Update web component version to 1.2.6 #125

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Update web component version to 1.2.6 #125

merged 1 commit into from
Mar 9, 2020

Conversation

Haprog
Copy link
Contributor

@Haprog Haprog commented Mar 9, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@vaadin-bot
Copy link

SonarQube analysis reported 5 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL RadioButton.java#L31: Make "item" transient or serializable. rule
  2. CRITICAL RadioButtonGroup.java#L97: Define a constant instead of duplicating this literal "value" 3 times. rule
  3. CRITICAL RadioButtonGroup.java#L126: Remove usage of generic wildcard type. rule
  4. CRITICAL RadioButtonGroup.java#L162: Remove usage of generic wildcard type. rule
  5. MINOR RadioButtonGroup.java#L88: Move this constructor to comply with Java Code Conventions. rule

@Haprog Haprog merged commit ab92fc0 into master Mar 9, 2020
@Haprog Haprog deleted the fix/update-wc-1.2.6 branch March 9, 2020 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Haprog @CLAassistant @vaadin-bot @tomivirkki