Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shadow-selection-polyfill #129

Closed
web-padawan opened this issue Feb 10, 2020 · 2 comments
Closed

Update shadow-selection-polyfill #129

web-padawan opened this issue Feb 10, 2020 · 2 comments
Assignees

Comments

@web-padawan
Copy link
Member

There is a new version released today: GoogleChromeLabs/shadow-selection-polyfill@ef88609

I will update my vaadin-quill branch to use this version and test how it works for us.

Potentially related issues: #49 #98 and maybe also #75 (need to verify).

@web-padawan web-padawan self-assigned this Feb 10, 2020
@web-padawan
Copy link
Member Author

web-padawan commented Feb 10, 2020

Tried to upgrade and got the following error:

[Error] TypeError: Argument 1 ('node') to Selection.containsNode must be an instance of Node
	containsNode
	getRange
	getNativeRange
	getRange
	update
	Selection
	Quill
	ready
	_enableProperties
	connectedCallback
	connectedCallback
	connectedCallback
	(anonymous function)
	appendChild
	insertBefore
	createFrom
	(anonymous function)
	forEach
	forElements
	create
	(anonymous function)
	callFn (mocha.js:1168:147)
	(anonymous function) (mocha.js:1168)
	next (mocha.js:1274:1388)
	(anonymous function) (mocha.js:1276:122)
	timeslice (mocha.js:17:244)

The error is only thrown when ShadyDOM is in use.

@web-padawan
Copy link
Member Author

Done by #145. We do not apply polyfill in ShadyDOM now so the above error should not happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant