Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar buttons not clickable on Safari #130

Closed
TGit911iger opened this issue Mar 24, 2020 · 4 comments · Fixed by #145
Closed

Toolbar buttons not clickable on Safari #130

TGit911iger opened this issue Mar 24, 2020 · 4 comments · Fixed by #145
Assignees
Labels

Comments

@TGit911iger
Copy link

Hello!

I am using Rich Text Editor with Vaadin 15.0.2 and Vaadin 14.1.20.

There is a problem with Safari, with Chrome there are no problems.

Of course I tried this with your sample: https://demo.vaadin.com/invoice-editor-app/

It is not working, too.

Here is the problem:

In your sample I am selecting the text "hotel" and pressing the bold button. Under Safari the caret jumps to the beginning of the text when pressing the bold button. Under Chrome "hotel" is marked bold - ok.

There may be a problem with "window.getSelection" under Safari.

System is mac.png.

Thank you very much for your help, Thomas
mac
editor

@web-padawan web-padawan added the bug Something isn't working label Mar 24, 2020
@web-padawan
Copy link
Member

Thanks for the issue. Confirmed using Safari 13.0.5.

Can be also reproduced with 1.0.0 demos, so not a regression of web component.

We are using getSelection polyfill, but unfortunately it has some edge cases. One possible solution could be to test if the newer polyfill version helps, as reported in #129

tomivirkki added a commit that referenced this issue Apr 9, 2020
A recent change in Safari causes various issues with the component #130. Should be investigated separately
@tomivirkki tomivirkki changed the title Error in selection Toolbar buttons not clickable on Safari May 22, 2020
@yuriy-fix yuriy-fix self-assigned this Jun 11, 2020
@omair100
Copy link

Hi

Is there any progress on this issue - as our users are experiencing the same issue in safari.

Best Regards

@PaulQDC
Copy link

PaulQDC commented Oct 8, 2020

Why has this issue been closed ? Still happening on latest OS and Vaadin version 14.3.0. If was closed with a fix, what is the fix? This is NOT a minor issue or inconvenience for us. It is a SHOW STOPPER.

@web-padawan
Copy link
Member

@PaulQDC this is closed because the fix was merged and released. Please upgrade to Vaadin 14.3.9 or 14.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants