fix: replace selection polyfill in quill to handle Safari selection issues #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sissbruecker
changed the title
sissbruecker
force-pushed
the
refacot/replace-quill-selection-polyfill
branch
from
c34b486
to
1f8abd7
Compare
sissbruecker
commented
Sep 15, 2021
hdamr
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
I checked RTE demo pages on various versions of iOS (10.3, 11.2, 12.1,13.3, 14.3) and it worked as expected and no problem was seen. Also other browsers (IE11, FF, Edge) were tested and it was working fine, both RTE functionality and also adding an extra input field on the page to test typing into input field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Quill dependency to use a new polyfill for shadow DOM text selection (related PR: vaadin/quill#2).
Fixes: vaadin/web-components#2115
Fixes: vaadin/web-components#2139 - this one is about text input and selection not working in any Vaadin component in iOS 12, which is also caused by the old polyfill