Skip to content

Commit

Permalink
Update renderer args and bump analysis.json
Browse files Browse the repository at this point in the history
  • Loading branch information
yuriy-fix committed Aug 24, 2018
1 parent 3f6d001 commit ffc6b60
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
9 changes: 2 additions & 7 deletions src/vaadin-dropdown-menu.html
Original file line number Diff line number Diff line change
Expand Up @@ -151,18 +151,13 @@

/**
* Custom function for rendering the content of the `<vaadin-dropdown-menu>`.
* Receives arguments `root`, `owner`, `model`
* Receives arguments `root`, `dropdownMenu`
*
* `root` the `<vaadin-dropdown-menu-overlay>` internal container element
*
* `owner` the `<vaadin-dropdown-menu>` element
*
* `model` null
* `dropdownMenu` the reference to the dropdown menu element
*
* **NOTE:** The renderer callback can be called multiple times with the previous content.
*
* **NOTE:** `<vaadin-dropdown-menu>` does not have any specific properties to pass with the `model` object,
* it is set to null.
*/
renderer: {
type: Function,
Expand Down
4 changes: 2 additions & 2 deletions test/renderer.html
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
});

it('should pass vaadin-dropdown-menu as owner to vaadin-overlay', () => {
dropdown.renderer = (root, owner, model) => {
expect(owner).to.eql(dropdown);
dropdown.renderer = (root, dropdownMenu, model) => {
expect(dropdownMenu).to.eql(dropdown);
};
});
});
Expand Down

0 comments on commit ffc6b60

Please sign in to comment.