fix: cleanup slot attribute on removed nodes (#166)

vaadin · Feb 28, 2022 · b4ff18e · b4ff18e
1 parent ebf04bb
commit b4ff18e
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/src/vaadin-split-layout.html b/src/vaadin-split-layout.html
@@ -260,7 +260,17 @@
         /** @protected */
         ready() {
           super.ready();
-          new Polymer.FlattenedNodesObserver(this, this._processChildren);
+          new Polymer.FlattenedNodesObserver(this, (info) => {
+            this._cleanupNodes(info.removedNodes);
+            this._processChildren();
+          });
+        }
+
+        /** @private */
+        _cleanupNodes(nodes) {
+          nodes.forEach((node) => {
+            node.removeAttribute('slot');
+          });
         }
 
         /** @private */

diff --git a/test/vaadin-split-layout_test.html b/test/vaadin-split-layout_test.html
@@ -398,6 +398,24 @@
 
       });
 
+      describe('removing nodes', () => {
+        beforeEach(done => {
+          splitLayout = fixture('split-layout');
+          setTimeout(() => {
+            first = splitLayout.$.primary.assignedNodes({flatten: true})[0];
+            second = splitLayout.$.secondary.assignedNodes({flatten: true})[0];
+            done();
+          }, 1);
+        });
+
+        it('should remove slot attribute from the removed node', (done) => {
+          splitLayout.removeChild(first);
+          setTimeout(() => {
+            expect(first.hasAttribute('slot')).to.be.false;
+            done();
+          });
+        });
+      });
     </script>
   </body>
 </html>