Fix style scope issues in dynamically named slotted items

[tomivirkki]

Fixes vaadin/vaadin-grid#1306
Fixes vaadin/vaadin-grid#1227

---

This change is 

[manolo]

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.

---

src/vaadin-split-layout.html, line 69 at r1 (raw file):

    <slot id="secondary" name="secondary"></slot>

    <div hidden>

Could this trick be documented in code somehow. It took a while to me tu understand how this fixes the issue after reading the tickets. I suspect that in the future someone reading this might ask why this is here.

---

Comments from Reviewable

[tomivirkki]

src/vaadin-split-layout.html, line 69 at r1 (raw file):

Previously, manolo (Manuel Carrasco Moñino) wrote…

Could this trick be documented in code somehow. It took a while to me tu understand how this fixes the issue after reading the tickets. I suspect that in the future someone reading this might ask why this is here.

I generally avoid adding comments to source because that's usually a sign of badly tested/organized code. Maybe in this case a comment could be in order. Done.

---

Comments from Reviewable

[manolo]

---

Review status: all files reviewed at latest revision, all discussions resolved.

---

src/vaadin-split-layout.html, line 69 at r1 (raw file):

Previously, tomivirkki (Tomi Virkki) wrote…

I generally avoid adding comments to source because that's usually a sign of badly tested/organized code. Maybe in this case a comment could be in order. Done.

Sure, I neither like comments unless they are strictly necessary. Much clearer now.

---

Comments from Reviewable

[limonte]

---

Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from Reviewable