Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not throw when layout has only one child #128

Merged
merged 2 commits into from
Jun 25, 2019
Merged

fix: do not throw when layout has only one child #128

merged 2 commits into from
Jun 25, 2019

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Jun 25, 2019 •
edited by platosha
Loading

Fixes #123

There is already such a check in _onHandleTrack listener. Let's add it in other listeners, too.

This change is Reviewable

@web-padawan web-padawan merged commit 8d962f6 into master Jun 25, 2019
@web-padawan web-padawan deleted the fix/123 branch June 25, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<vaadin-split-layout> produces an error when it has only one (visible) child
2 participants
@web-padawan @tomivirkki