Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs with "minimal" theme are not accessible enough #77

Closed
web-padawan opened this issue Feb 5, 2018 · 1 comment
Closed

Tabs with "minimal" theme are not accessible enough #77

web-padawan opened this issue Feb 5, 2018 · 1 comment
Assignees
@jouni

Comments

@web-padawan
Copy link
Member

Currently, the main focus indicator for tabs is underline (color and transitions), but this is not an option for theme="minimal" and the text color change is not enough. When focusing the tab which is selected at the same time, no style change happens at all:

minimal

I'm wondering if we could just use plain old native outline for cases like this.
@jouni
Copy link
Member

jouni commented Feb 5, 2018

Yeah, good point. An outline would probably be in order. Perhaps not the native one, though, but the same style as used for buttons and list items at the moment (a 2px --lumo-primary-color-50pct outer shadow).

jouni added a commit that referenced this issue Feb 7, 2018
@jouni
Explicit focus ring style
6d6116e 
Use a similar focus-ring style as for many other elements (2px blue outline).

Remove unnecessary background-color override (no default theme anymore).

Center align text (nicer when the tab label wraps on multiple lines).

Fixes #77
@jouni jouni mentioned this issue Feb 7, 2018
Merged
@jouni jouni self-assigned this Feb 7, 2018
@jouni jouni added the in review label Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jouni jouni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jouni @web-padawan @yuriy-fix