Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme centered #101

Merged
merged 3 commits into from Jul 24, 2018
Merged

Theme centered #101

merged 3 commits into from Jul 24, 2018

Conversation

yuriy-fix
Copy link
Contributor

@yuriy-fix yuriy-fix commented Jun 20, 2018

@tamasnet, Once again, thank you for your contribution!
I have implemented requested changes and made a new PR based on #99.


This change is Reviewable

@coveralls
Copy link

coveralls commented Jun 20, 2018

Pull Request Test Coverage Report for Build 999

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-10.7%) to 83.929%

Files with Coverage Reduction New Missed Lines %
src/vaadin-tabs.html 4 82.61%
Totals Coverage Status
Change from base Build 996: -10.7%
Covered Lines: 32
Relevant Lines: 38

💛 - Coveralls

@yuriy-fix yuriy-fix self-assigned this Jul 11, 2018
Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuriyvaadin please rebase, the branch has conflicts with master.

:lgtm:

Reviewed 2 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @YuriyVaadin)

@limonte
Copy link
Contributor

limonte commented Jul 12, 2018

ping @YuriyVaadin

@yuriy-fix
Copy link
Contributor Author

Rebased.

Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @YuriyVaadin)

Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @YuriyVaadin)

@platosha platosha merged commit 1f4beec into master Jul 24, 2018
@platosha platosha deleted the theme-centered branch July 24, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants