Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent text selection on tabs (Lumo) #117

Merged
merged 1 commit into from Dec 18, 2018
Merged

Conversation

jouni
Copy link
Member

@jouni jouni commented Dec 17, 2018

This change is Reviewable

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can potentially prevent selecting text by accident on mobile. On the Android Chrome I was only able to reach this using long touch on not selected tab, which does not activate it.

@web-padawan
Copy link
Member

@jouni FYI in other components we have (probably inconsistent) un-prefixed version + -webkit prefix, but no prefixes for -moz and -ms:

https://github.com/vaadin/vaadin-checkbox/blob/e6af29c04e5eec119f4b40a0c14a650479b6b161/theme/lumo/vaadin-checkbox-styles.html#L22

https://github.com/vaadin/vaadin-radio-button/blob/9bb42bd4e9556d3b523ab9c761cb6eddaefc2ceb/theme/lumo/vaadin-radio-button-styles.html#L9

I think it is good idea to align those. Will do it on master where appropriate.

@web-padawan web-padawan merged commit 09f2a01 into master Dec 18, 2018
@web-padawan web-padawan deleted the lumo-tab-text-select branch December 18, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants