Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update links demo to inclulde icons [skip ci] #125

Merged
merged 1 commit into from
Mar 7, 2019
Merged

docs: update links demo to inclulde icons [skip ci] #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions demo/demo-iconset.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<link rel="import" href="../../iron-iconset-svg/iron-iconset-svg.html">

<iron-iconset-svg size="24" name="custom-icons">
<svg>
<defs>
<g id="external"><path d="M19 19H5V5h7V3H5c-1.11 0-2 .9-2 2v14c0 1.1.89 2 2 2h14c1.1 0 2-.9 2-2v-7h-2v7zM14 3v2h3.59l-9.83 9.83 1.41 1.41L19 6.41V10h2V3h-7z"></path></g>
</defs>
</svg>
</iron-iconset-svg>
1 change: 1 addition & 0 deletions demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
<link rel="import" href="../vaadin-tabs.html">
<link rel="import" href="../vaadin-tab.html">
<link rel="import" href="../demo/my-custom-item.html">
<link rel="import" href="demo-iconset.html">

<custom-style>
<style include="vaadin-component-demo-shared-styles"></style>
Expand Down
20 changes: 16 additions & 4 deletions demo/tabs-basic-demos.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,21 +98,33 @@ <h3>Pre-selected tab</h3>
</template>
</vaadin-demo-snippet>

<h3>Anchors</h3>
<h3>Links</h3>
<p>
<b>Note:</b> wrapping tab content into <code>&lt;a&gt;</code> introduces a limitation of styling slotted
elements, like icons, by the <code>&lt;vaadin-tabs&gt;</code> theme.
</p>
<vaadin-demo-snippet id='tabs-basic-demos-anchors'>
<vaadin-demo-snippet id='tabs-basic-demos-links'>
<template preserve-content>
<vaadin-tabs>
<vaadin-tab>
<a href="https://vaadin.com/components/vaadin-tabs/install" tabindex="-1">Installation</a>
<a href="https://vaadin.com/components/vaadin-tabs/install" tabindex="-1" target="_blank" rel="noopener">
Installation
<iron-icon icon="custom-icons:external"></iron-icon>
</a>
</vaadin-tab>
<vaadin-tab>
<a href="https://vaadin.com/components/vaadin-tabs/html-api" tabindex="-1">API docs</a>
<a href="https://vaadin.com/components/vaadin-tabs/html-api" tabindex="-1" target="_blank" rel="noopener">
API docs
<iron-icon icon="custom-icons:external"></iron-icon>
</a>
</vaadin-tab>
</vaadin-tabs>
<style>
iron-icon {
box-sizing: border-box;
padding: 4px;
}
</style>
</template>
</vaadin-demo-snippet>

Expand Down