Merge 3603510 into 83f2943

vaadin · Jun 12, 2020 · 1d0584b · 1d0584b
2 parents 83f2943 + 3603510
commit 1d0584b
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/vaadin-text-field-mixin.html b/src/vaadin-text-field-mixin.html
@@ -389,7 +389,9 @@
       if (!e.__fromClearButton) {
         this.__userInput = true;
       }
+
       this.value = e.target.value;
+      this.__userInput = false;
     }
 
     // NOTE(yuriy): Workaround needed for IE11 and Edge for proper displaying
@@ -436,7 +438,6 @@
       }
 
       if (this.__userInput) {
-        this.__userInput = false;
         return;
       } else if (newVal !== undefined) {
         this.inputElement.value = newVal;

diff --git a/test/text-field.html b/test/text-field.html
@@ -439,6 +439,26 @@
 
       });
 
+      describe('value property', function() {
+        let textField, input;
+
+        beforeEach(function() {
+          textField = fixture(`default${fixtureName}`);
+          input = textField.inputElement;
+        });
+
+        it('should not consider updating the value as user input if the value is not changed', () => {
+          const event = new Event('input', {
+            bubbles: true,
+            cancelable: true
+          });
+          input.dispatchEvent(event);
+
+          textField.value = 'foo';
+          expect(input.value).to.equal('foo');
+        });
+      });
+
       describe(`events ${condition}`, function() {
         let textField, input;