Align text field to baseline

vaadin · Oct 8, 2018 · 538aadd · 538aadd
1 parent 14ebcb8
commit 538aadd
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 2 deletions.
diff --git a/bower.json b/bower.json
@@ -38,7 +38,8 @@
     "webcomponentsjs": "^1.0.0",
     "web-component-tester": "^6.1.5",
     "vaadin-demo-helpers": "vaadin/vaadin-demo-helpers#^2.1.0",
-    "vaadin-button": "vaadin/vaadin-button#^2.1.0"
+    "vaadin-button": "vaadin/vaadin-button#^2.1.0",
+    "vaadin-ordered-layout": "vaadin/vaadin-ordered-layout#^1.1.0"
   },
   "dependencies": {
     "polymer": "^2.0.0",
@@ -49,6 +50,8 @@
     "vaadin-element-mixin": "vaadin/vaadin-element-mixin#^2.0.0"
   },
   "resolutions": {
-    "vaadin-element-mixin": "^2.0.0"
+    "vaadin-element-mixin": "^2.0.0",
+    "vaadin-development-mode-detector": "^2.0.0",
+    "vaadin-usage-statistics": "^2.0.1"
   }
 }
diff --git a/src/vaadin-text-field-mixin.html b/src/vaadin-text-field-mixin.html
@@ -13,6 +13,7 @@
       :host {
         display: inline-flex;
         outline: none;
+        align-self: baseline;
       }
 
       :host::before {

diff --git a/.../visual/screens/vaadin-text-field/text-field-integration/integration/chrome.png b/.../visual/screens/vaadin-text-field/text-field-integration/integration/chrome.png
diff --git a/...visual/screens/vaadin-text-field/text-field-integration/integration/firefox.png b/...visual/screens/vaadin-text-field/text-field-integration/integration/firefox.png
diff --git a/test/visual/test.js b/test/visual/test.js
@@ -52,6 +52,13 @@ gemini.suite('vaadin-text-field', function(rootSuite) {
         .capture('password-field');
     });
 
+    gemini.suite('text-field-integration-${theme}', function(suite) {
+      suite
+        .setUrl('vaadin-text-field/integration.html')
+        .setCaptureElements('#integration')
+        .capture('integration');
+    });
+
     gemini.suite(`password-field-rtl-${theme}`, function(suite) {
       suite
         .setUrl(`vaadin-password-field/rtl.html?theme=${theme}`)

diff --git a/test/visual/vaadin-text-field/integration.html b/test/visual/vaadin-text-field/integration.html
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+
+<head lang="ar">
+  <meta charset="UTF-8">
+  <title></title>
+  <script src="../../../../webcomponentsjs/webcomponents-loader.js"></script>
+  <link href="../../../vaadin-text-field.html" rel="import">
+  <script src="../../../../vaadin-ordered-layout/vaadin-horizontal-layout.html"></script>
+  <link href="../common.html" rel="import">
+</head>
+
+<body>
+  <form>
+    <fieldset id="integration">
+      <p>vaadin-horizontal-layout</p>
+      <vaadin-horizontal-layout>
+        <vaadin-text-field  error-message="Please enter a value" required invalid label="Required"></vaadin-text-field>
+        <vaadin-text-field label="Label"></vaadin-text-field>
+      </vaadin-horizontal-layout>
+    </fieldset>
+</body>