Merge 857bc64 into 9278daf

vaadin · Apr 30, 2020 · 6293d7d · 6293d7d
2 parents 9278daf + 857bc64
commit 6293d7d
Show file tree

Hide file tree

Showing 7 changed files with 26 additions and 3 deletions.
diff --git a/src/vaadin-number-field.html b/src/vaadin-number-field.html
@@ -42,6 +42,28 @@
         /* Older Firefox versions (v47.0) requires !important */
         -moz-appearance: textfield !important;
       }
+
+      :host([dir="rtl"]) [part="input-field"] {
+        direction: ltr;
+      }
+
+      :host([dir="rtl"]) [part="value"]::placeholder {
+        direction: rtl;
+      }
+
+      :host([dir="rtl"]) [part="input-field"] ::slotted(input)::placeholder {
+        direction: rtl;
+      }
+
+      :host([dir="rtl"]) [part="value"]:-ms-input-placeholder,
+      :host([dir="rtl"]) [part="input-field"] ::slotted(input):-ms-input-placeholder {
+        direction: rtl;
+      }
+
+      :host([dir="rtl"]:not([has-controls])) [part="value"]::placeholder,
+      :host([dir="rtl"]:not([has-controls])) [part="input-field"] ::slotted(input)::placeholder {
+        text-align: left;
+      }
     </style>
 
     <div

diff --git a/test/visual/screens/vaadin-text-field/number-field-rtl-lumo/rtl/chrome.png b/test/visual/screens/vaadin-text-field/number-field-rtl-lumo/rtl/chrome.png
diff --git a/test/visual/screens/vaadin-text-field/number-field-rtl-lumo/rtl/firefox.png b/test/visual/screens/vaadin-text-field/number-field-rtl-lumo/rtl/firefox.png
diff --git a/test/visual/screens/vaadin-text-field/number-field-rtl-material/rtl/chrome.png b/test/visual/screens/vaadin-text-field/number-field-rtl-material/rtl/chrome.png
diff --git a/test/visual/screens/vaadin-text-field/number-field-rtl-material/rtl/firefox.png b/test/visual/screens/vaadin-text-field/number-field-rtl-material/rtl/firefox.png
diff --git a/test/visual/vaadin-number-field/rtl.html b/test/visual/vaadin-number-field/rtl.html
@@ -23,6 +23,7 @@
 
   <fieldset id="rtl">
     <vaadin-number-field label="كلمه السر" placeholder="أنشئ كلمة مرور"></vaadin-number-field>
+    <vaadin-number-field label="كلمه السر" value="987654321987"></vaadin-number-field>
   </fieldset>
 
 </body>
diff --git a/theme/lumo/vaadin-text-field-styles.html b/theme/lumo/vaadin-text-field-styles.html
@@ -297,9 +297,9 @@
         transform-origin: 0% 0;
       }
 
-      :host([dir="rtl"]) [part="value"],
-      :host([dir="rtl"]) [part="input-field"] ::slotted(input),
-      :host([dir="rtl"]) [part="input-field"] ::slotted(textarea) {
+      :host([dir="rtl"]:not(vaadin-number-field):not(vaadin-big-decimal-field)) [part="value"],
+      :host([dir="rtl"]:not(vaadin-number-field):not(vaadin-big-decimal-field)) [part="input-field"] ::slotted(input),
+      :host([dir="rtl"]:not(vaadin-number-field):not(vaadin-big-decimal-field)) [part="input-field"] ::slotted(textarea) {
         --_lumo-text-field-overflow-mask-image: linear-gradient(to right, transparent, #000 1.25em);
       }