Don't throw an error when focusing a newly created text-field

vaadin · Nov 8, 2018 · 9153ada · 9153ada
1 parent 9819386
commit 9153ada
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/vaadin-text-field-mixin.html b/src/vaadin-text-field-mixin.html
@@ -236,7 +236,7 @@
     }
 
     get focusElement() {
-      return this.root.querySelector('[part=value]');
+      return this.root && this.root.querySelector('[part=value]');
     }
 
     _onInput(e) {

diff --git a/test/text-field.html b/test/text-field.html
@@ -226,5 +226,12 @@
         });
       });
     });
+
+    describe('methods', function() {
+      it('should not throw an error when using focus() to a newly created element', () => {
+        // No expect needed as an error is thrown when focusing undefined element
+        document.createElement('vaadin-text-field').focus();
+      });
+    });
   </script>
 </body>