fix(number-field): reflect to attribute properly (#384)

vaadin · Jun 14, 2019 · d4f2584 · d4f2584
1 parent 22af86b
commit d4f2584
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/src/vaadin-number-field.html b/src/vaadin-number-field.html
@@ -102,15 +102,15 @@
             */
             min: {
               type: Number,
-              reflectToAttribue: true
+              reflectToAttribute: true
             },
 
             /**
              * The maximum value of the field.
              */
             max: {
               type: Number,
-              reflectToAttribue: true,
+              reflectToAttribute: true,
               observer: '_maxChanged'
             },
 
@@ -119,7 +119,7 @@
              */
             step: {
               type: Number,
-              reflectToAttribue: true,
+              reflectToAttribute: true,
               value: 1
             }
 

diff --git a/test/number-field.html b/test/number-field.html
@@ -37,6 +37,16 @@
         increaseButton = numberField.root.querySelector('[part=increase-button]');
       });
 
+      describe('properties', () => {
+        ['min', 'max', 'step'].forEach(prop => {
+          it(`should reflect "${prop}" property to attribute`, () => {
+            var value = 5;
+            numberField[prop] = value;
+            expect(numberField.getAttribute(prop)).to.be.equal(String(value));
+          });
+        });
+      });
+
       describe('native', () => {
 
         it('should have [type=number]', () => {
@@ -528,7 +538,7 @@
             expect(numberField.value).to.be.equal('19');
           });
 
-          it(`should set value to the first step value above zero when min is below zero 
+          it(`should set value to the first step value above zero when min is below zero
               and max is above zero and increaseButton is clicked`, () => {
             numberField.min = -19;
             numberField.max = 19;
@@ -569,7 +579,7 @@
             expect(numberField.value).to.be.equal('-3');
           });
 
-          it(`should set value to the first step value below zero when min is below zero and max 
+          it(`should set value to the first step value below zero when min is below zero and max
               is above zero and decreaseButton is clicked`, () => {
             numberField.min = -19;
             numberField.max = 19;