Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSDoc annotation for title property is confusing #293

Closed
web-padawan opened this issue Jan 3, 2019 · 0 comments · Fixed by #419
Closed

JSDoc annotation for title property is confusing #293

web-padawan opened this issue Jan 3, 2019 · 0 comments · Fixed by #419
Labels
documentation Improvements or additions to documentation
Projects
vaadin-core

Comments

@web-padawan
Copy link
Member

Description

Current JSDoc for title property says the following:

Message to show to the user when validation fails

It was added at the time of early prototype: 97cbacd

We have errorMessage for that, and the JSDoc for title should be changed to something more descriptive, e.g. Title bound to the native input title attribute
@web-padawan web-padawan added the documentation Improvements or additions to documentation label Jan 3, 2019
@jtomass jtomass added this to 📬  Inbox in vaadin-core Mar 29, 2019
@web-padawan web-padawan mentioned this issue Oct 4, 2019
Closed
pekam added a commit that referenced this issue Oct 4, 2019
@pekam
docs: fix title-property JSDoc
862e991 
based on https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title

fix #293
pekam added a commit that referenced this issue Oct 4, 2019
@pekam
docs: fix title-property JSDoc [skip ci]
bf4e07a 
based on https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title

fix #293
@pekam pekam mentioned this issue Oct 4, 2019
Merged
web-padawan pushed a commit that referenced this issue Oct 4, 2019
@pekam @web-padawan
docs: fix title-property JSDoc [skip ci] (#419)
7599194 
based on https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title

fix #293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
No open projects
vaadin-core
  
📬  Inbox
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: fix title-property JSDoc [skip ci] vaadin/vaadin-text-field
1 participant
@web-padawan