Align text field to baseline #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiheikki
force-pushed
the
fix/horizontal-layout
branch
2 times, most recently
from
2f109d5
to
d76688e
Compare
yuriy-fix
force-pushed
the
fix/horizontal-layout
branch
from
d76688e
to
34d38ef
Compare
yuriy-fix
force-pushed
the
fix/horizontal-layout
branch
from
8f0caf8
to
22f0dd7
Compare
samiheikki
commented
Oct 18, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 14 files reviewed, all discussions resolved
|
@jouni WDYT about this change? |
|
Well, I did propose the fix, so looks okay to me. |
jouni
approved these changes
Oct 19, 2018
web-padawan
approved these changes
Oct 19, 2018
There was a problem hiding this comment.
Reviewed 3 of 6 files at r1, 11 of 11 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #246
This change is