Prevent setting value over max and under min limit #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
requested changes
Jan 22, 2019
| @@ -209,6 +209,12 @@ | |||
| } | |||
|
|
|||
| __onInputChange() { | |||
| if (this.min && this.value < this.min) { | |||
There was a problem hiding this comment.
these two conditions will likely fail for this.min === 0 and this.max === 0
please use more strict assertion, e.g. !isNaN(this.min)
|
Ah, the idea wasn't to automatically fix the value but to prevent the field from going invalid while the user is typing. This occurred during UX tests but can't seem to be able to reproduce now. @web-padawan let's close this PR if this isn't reproducible |
|
Apparently this was because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "Typing 3, then 2 will result in invalid appearance for a number field with max of 31"
This change is