Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dispatch iron-resize event to notify for height changes #383

Merged
merged 1 commit into from Jun 17, 2019
Merged

fix: dispatch iron-resize event to notify for height changes #383

merged 1 commit into from Jun 17, 2019

Conversation

platosha
Copy link
Contributor

@platosha platosha commented Jun 12, 2019 •
edited by tomivirkki

Fixes #372

This change is Reviewable

web-padawan
web-padawan reviewed Jun 13, 2019
View reviewed changes
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we consider this as a bug fix, and mark the commit as fix: instead of feat: ?

We have previously done that e.g. when adding missing change event.
I feel this is a small change and it could be a patch release.

@platosha platosha force-pushed the feat/notify-resize branch 5 times, most recently from 0126db5 to ac8eb58 Compare June 14, 2019 12:38
@platosha
Copy link
Contributor Author

Can we consider this as a bug fix, and mark the commit as fix: instead of feat: ?

We have previously done that e.g. when adding missing change event.
I feel this is a small change and it could be a patch release.

Done.

@platosha platosha changed the title feat: dispatch iron-resize event to notify for height changes fix: dispatch iron-resize event to notify for height changes Jun 17, 2019
@web-padawan web-padawan merged commit 338b26d into master Jun 17, 2019
@web-padawan web-padawan deleted the feat/notify-resize branch June 17, 2019 09:39
@tomivirkki tomivirkki mentioned this pull request Feb 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

@yuriy-fix yuriy-fix yuriy-fix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the height of the component should notify the iron-resize
3 participants
@platosha @web-padawan @yuriy-fix