feat/refactor: add _enabledCharPattern property #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protected feature extracted from <vaadin-integer-field> to allow reusing the same logic for BigDecimalField.
tomivirkki
approved these changes
Oct 15, 2019
|
New tests were not added for this generic feature. The coverage of the existing |
Haprog
added a commit
that referenced
this pull request
Nov 28, 2019
This introduces the fixes done between 2.5.0-alpha1 - 2.5.3 into the 2.6 branch. 2.6 branch was based off of 2.5.0-alpha1 but it already had most of the fixes in 2.5.0-alpha2 except for "feat/refactor: add _enabledCharPattern property (#424)".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protected feature extracted from
<vaadin-integer-field>to allowreusing the same logic for
BigDecimalField.