Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

min and max type is string (not LocalTime) #55

Closed
mstahv opened this issue Sep 2, 2019 · 3 comments
Closed

min and max type is string (not LocalTime) #55

mstahv opened this issue Sep 2, 2019 · 3 comments

Comments

@mstahv
Copy link
Member

mstahv commented Sep 2, 2019

Screenshot 2019-09-02 at 16 27 00

@Haprog
Copy link
Contributor

Haprog commented Sep 2, 2019

Related: https://vaadin.com/forum/thread/17821234/timepicker-setmin-vs-datepicker-setmin

@pleku
Copy link
Contributor

pleku commented Sep 2, 2019

Absolutely agree, it makes no sense as a String for Java side. The contribution should have not passed review.

sahalsaad added a commit to sahalsaad/vaadin-time-picker-flow that referenced this issue Oct 8, 2019
@sahalsaad
vaadin#55 Change min & max to LocalTime.
b135d1d
sahalsaad added a commit to sahalsaad/vaadin-time-picker-flow that referenced this issue Oct 9, 2019
@sahalsaad
vaadin#55 Change min & max to LocalTime. Deprecated min & max string.
590a144
tulioag pushed a commit that referenced this issue Dec 4, 2019
@sahalsaad
#55 Change min & max to LocalTime. (#57)
51f9684 
* Improve error handling in connector: wrap with try catch

* Return result from the tryCatchWrapper

* #55 Change min & max to LocalTime. Deprecated min & max string.

* Update based on PR comment.
@tulioag
Copy link
Contributor

tulioag commented Dec 10, 2019

Fixed by #57

@tulioag tulioag closed this as completed Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Haprog @mstahv @pleku @tulioag