Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

setMin and setMax do not accept null #61

Closed
OlliTietavainenVaadin opened this issue Nov 28, 2019 · 0 comments · Fixed by #62
Closed

setMin and setMax do not accept null #61

OlliTietavainenVaadin opened this issue Nov 28, 2019 · 0 comments · Fixed by #62
Assignees
@DiegoCardoso

Comments

@OlliTietavainenVaadin
Copy link
Member

Related: #57

If you try to call setMinor setMax with a null value, you will get a NullPointerException even though the JavaDocs say that null can be used to remove the min/max limits.
@DiegoCardoso DiegoCardoso self-assigned this Dec 2, 2019
DiegoCardoso added a commit that referenced this issue Dec 4, 2019
@DiegoCardoso
Fix setMin/setMax when called with null
3d6c3c9 
Check for null on the argument before passing it to `LocalTime#parse`.
Add tests for this case.

Fixes #61
@DiegoCardoso DiegoCardoso mentioned this issue Dec 4, 2019
Merged
DiegoCardoso added a commit that referenced this issue Dec 4, 2019
@DiegoCardoso
Fix setMin/setMax when called with null (#62)
a9fb455 
Check for null on the argument before passing it to `LocalTime#parse`.
Add tests for this case.

Fixes #61
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DiegoCardoso DiegoCardoso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix setMin/setMax when called with null vaadin/vaadin-time-picker-flow
2 participants
@DiegoCardoso @OlliTietavainenVaadin