Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: read-only styles missing when in read only mode #134

Merged
merged 3 commits into from
Mar 18, 2020
Merged

Fix: read-only styles missing when in read only mode #134

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a3e55f
fix/Read-only styles missing for toggle-button #131
Harry-Ph Mar 17, 2020
1793c44
refactor code
Harry-Ph Mar 17, 2020
dba309a
change template literal to single quote in the test
Harry-Ph Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/vaadin-time-picker.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@
*/
readonly: {
type: Boolean,
value: false
value: false,
reflectToAttribute: true
},

/**
Expand Down
5 changes: 5 additions & 0 deletions test/input-test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,11 @@
});
});

it(`should reflect to attribute when readonly property is set`, () => {
Haprog marked this conversation as resolved.
Show resolved Hide resolved
timePicker.readonly = true;
expect(timePicker.hasAttribute('readonly')).to.be.true;
});

describe('aria', () => {
it('text-field should have the `aria-label` attribute', () => {
expect(timePicker.__inputElement.hasAttribute('aria-label')).to.be.false;
Expand Down