-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prepare for TS defs generation #150
Conversation
/** @private */ | ||
_getInputElement() { | ||
return this.shadowRoot.querySelector('vaadin-time-picker-text-field'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure what to do with this. I feel like this _getInputElement
should be private and the __inputElement
getter below should be protected, but their number of underscores implies the exact opposite. So now they're both private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add @type {string}
for placeholder
, min
and max
properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Properties
value
,placeholder
,min
,max
should have@type {string}
- Double underscored properties/methods should have explicit
@private
:__dropdownItems
,__validDayDivisor()
,__onKeyDown()
,__onArrowPressWithStep()
,__dispatchStep()
,__getMsec()
,__getSec()
,__addStep()
,__updateDropdownItems()
,__generateDropdownList()
,__adjustValue()
,__valueChanged()
,__onInputChange()
,__updateValue()
,__updateInputValue()
,__validateTime()
,__getStepSegment()
,__formatISO()
,__parseISO()
,__inputElement()
,__dropdownElement()
- Single underscored properties/methods should have explicit
@protected
:ready()
Co-authored-by: Kari Söderholm <haprog@vaadin.com>
Closes #141
Generated TS definitions look like this:
vaadin-time-picker.d.ts
(updated)