Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow overriding _getInputElement() #151

Merged
merged 1 commit into from
May 29, 2020

Conversation

Haprog
Copy link
Contributor

@Haprog Haprog commented May 29, 2020

This was accidentally marked as @private for TS defs generation but it was originally correctly intended as @protected. This is overridden in vaadin-date-time-picker. See: 8730119#diff-f47a6ede93b6671ca3a69fb260ffacfc

This was accidentally marked as `@private` for TS defs generation but it was originally correctly intended as `@protected`. This is overridden in vaadin-date-time-picker. See: 8730119#diff-f47a6ede93b6671ca3a69fb260ffacfc
@Haprog Haprog requested a review from web-padawan May 29, 2020 08:52
@Haprog Haprog changed the title fix: allow overriding _getInputElement() fix: allow overriding _getInputElement() May 29, 2020
@web-padawan web-padawan merged commit 1d7ac39 into master May 29, 2020
@web-padawan web-padawan deleted the fix/allow-input-element-override branch May 29, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants