refactor: enforce hiding dialog host element (#3597)

vaadin · Mar 25, 2022 · 1d43cb2 · 1d43cb2
1 parent 07fcb38
commit 1d43cb2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/packages/dialog/src/vaadin-dialog.js b/packages/dialog/src/vaadin-dialog.js
@@ -175,7 +175,7 @@ class Dialog extends ThemePropertyMixin(ElementMixin(DialogDraggableMixin(Dialog
     return html`
       <style>
         :host {
-          display: none;
+          display: none !important;
         }
       </style>
 

diff --git a/packages/dialog/test/dialog.test.js b/packages/dialog/test/dialog.test.js
@@ -45,6 +45,19 @@ describe('vaadin-dialog', () => {
     });
   });
 
+  describe('host element', () => {
+    let dialog;
+
+    beforeEach(() => {
+      dialog = fixtureSync('<vaadin-dialog></vaadin-dialog>');
+    });
+
+    it('should enforce display: none to hide the host element', () => {
+      dialog.style.display = 'block';
+      expect(getComputedStyle(dialog).display).to.equal('none');
+    });
+  });
+
   describe('opened', () => {
     let dialog, backdrop, overlay;