refactor: enforce hiding dialog host element #3597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to vaadin/flow-components#2856
We'd like to add
HasStyle
toDialog
so that users would be able to set classes on the host element and then they would be propagated to thevaadin-dialog-overlay
element for styling.So we need to enforce
display: none
to ensure that setting CSS class on the host would not have any side effects.Type of change